Skip to content

[Non-breaking changes] Unify multiple keccakState interfaces#369

Closed
trinhdn2 wants to merge 1 commit intoBuildOnViction:upgrade-core-developfrom
trinhdn2:refactor/keccak-state
Closed

[Non-breaking changes] Unify multiple keccakState interfaces#369
trinhdn2 wants to merge 1 commit intoBuildOnViction:upgrade-core-developfrom
trinhdn2:refactor/keccak-state

Conversation

@trinhdn2
Copy link

@trinhdn2 trinhdn2 commented Jul 16, 2023

There are the same unexported keccakState interfaces across vm and trie package with the same definition:

type keccakState interface {
	hash.Hash
	Read([]byte) (int, error)
}

This PR unify and expose that interface in the crypto package.

Reference:

@trinhdn2 trinhdn2 changed the base branch from master to upgrade-core-develop July 16, 2023 12:44
@trinhdn2 trinhdn2 mentioned this pull request Jul 16, 2023
Closed
2 tasks
@tungng98 tungng98 added the non-breaking Enhancement that doesn't need a hardfork label Jul 16, 2023
@trinhdn2 trinhdn2 mentioned this pull request Sep 20, 2023
Open
7 tasks
@tungng98 tungng98 deleted the branch BuildOnViction:upgrade-core-develop December 10, 2023 16:51
@tungng98 tungng98 closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

non-breaking Enhancement that doesn't need a hardfork

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trinhdn2 @tungng98